Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -f for seeds #5991

Merged
merged 3 commits into from
Oct 5, 2022
Merged

add -f for seeds #5991

merged 3 commits into from
Oct 5, 2022

Conversation

dave-connors-3
Copy link
Contributor

@dave-connors-3 dave-connors-3 commented Oct 3, 2022

resolves #5990

Description

Seeds need -f too!

image

Checklist

@cla-bot cla-bot bot added the cla:yes label Oct 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@dave-connors-3 dave-connors-3 marked this pull request as ready for review October 3, 2022 16:44
@dave-connors-3 dave-connors-3 requested a review from a team October 3, 2022 16:44
@dave-connors-3 dave-connors-3 requested a review from a team as a code owner October 3, 2022 16:44
@lostmygithubaccount lostmygithubaccount added ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering support_rotation A good task to pick up during support rotation labels Oct 4, 2022
@leahwicz
Copy link
Contributor

leahwicz commented Oct 4, 2022

@jtcohen6 would we want this in the 1.3 release?

@jtcohen6
Copy link
Contributor

jtcohen6 commented Oct 4, 2022

@leahwicz Not worth the hassle / risk of backporting IMO. It will be good to have some exciting user-facing functionality in v1.4! Or we could include in the v1.3.1 patch if needed.

@emmyoop
Copy link
Member

emmyoop commented Oct 5, 2022

Thanks @dave-connors-3!

@emmyoop emmyoop merged commit 7dbdfc8 into main Oct 5, 2022
@emmyoop emmyoop deleted the full-refresh-for-seeds branch October 5, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering support_rotation A good task to pick up during support rotation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1285] [Feature] extend -f flag shorthand to other commands
6 participants